Certificates statements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle command failures more gracefully than continuously retrying. Failures are not logged Add table for certificates. (cherry picked from commit 9f580a6)
…ction of the logger instance into each datastore because groob is a doodoo head :) Move NewDatastore methods into unit tests Reinstate NewDB test Create certificates package including a Certificate type and a datastore. Began working on a method ackCertificateList in the connect service. Boilerplate for management service test. Renamed some tables in certificates migration, hopefully nobody notices. Applications response handler should be omitted from this branch. (cherry picked from commit 8bc2fc7)
…orm of the certificate data. Change statments to reflect table change from certificates to devices_certificates Add the CertificateList request type to the connect service's Acknowledge method Add certificates datastore to the management service, and add endpoints and request/responses for retrieving certificates by device uuid to the management endpoujnt. Kludge. commits regarding app service will be amended. (cherry picked from commit c723c80)
(cherry picked from commit 4e5fc1f)
(cherry picked from commit 66d5036)
(cherry picked from commit b6d4dca)
(cherry picked from commit 06bc231)
Rebase develop onto master (cherry picked from commit 775484d)
…cate list on a per device basis. This is because neither the common name nor the data could be used as a unique constraint in the certificates table. Few small changes to imports/style. (cherry picked from commit e0a63e1)
…a response. (cherry picked from commit 99e1ea1)
…g the certificates management endpoint from listing certs. Certificate listing is working without a base64 encoded representation of each certificate. (cherry picked from commit 685dfef)
Add simple test for commands index Add commands index endpoint (cherry picked from commit 4e2a2a2)
(cherry picked from commit ae71b8f)
…tches a response can be retrieved by the connect service. Added Find() method to command service (cherry picked from commit ebceb28)
# Conflicts: # connect/service.go
# Conflicts: # connect/service.go # main.go # management/service.go # management/transport.go
These are necessary to support the current revision of the installed_certificates package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The certificates datastore still uses this statement module that i built in order to construct SQL queries. I'm including it now so micromdm does not explode, and we can look at the state of SQL building later.