Guard aginst tls=false and supplying cert&key #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groob
approved these changes
May 12, 2018
cmd/micromdm/serve.go
Outdated
| @@ -121,6 +121,9 @@ func serve(args []string) error { | |||
| if !strings.HasPrefix(*flServerURL, "https://") { | |||
| return errors.New("-server-url must begin with https://") | |||
| } | |||
| if *flTLS == false && (*flTLSCert != "" || *flTLSKey != "") { | |||
Lepidopteron
pushed a commit
to Lepidopteron/micromdm
that referenced
this pull request
Feb 11, 2021
Lepidopteron
pushed a commit
to Lepidopteron/micromdm
that referenced
this pull request
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#268 talks about a situation where it's not clear that supplying a certificate and key will magically turn on
-tls=true. Thus, forbid starting micromdm using those options together).