-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: tidy for go 1.20 #902
Conversation
i notice a few (most?) of the newline changes are removing newlines from text that is directly output. i.e. it’s for formatting/output style on a console. does your PR maintain that same formatting? |
I've made all but one out be md5 identical to previous - the previous output had a trailing whitespace on one line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I also updated the Go versions for CI and the Dockerfile, and updated the CHANGELOG.
Go 1.20's
test
will fail mdmctl because of strings with trailing newlines. This PR removes the newlines, and adds 1.20 to the build matrix.I also tidied three minor complaints from staticcheck.