Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: tidy for go 1.20 #902

Merged
merged 9 commits into from
Jul 11, 2023
Merged

Conversation

jamesez
Copy link
Contributor

@jamesez jamesez commented Jul 11, 2023

Go 1.20's test will fail mdmctl because of strings with trailing newlines. This PR removes the newlines, and adds 1.20 to the build matrix.

I also tidied three minor complaints from staticcheck.

@jamesez jamesez marked this pull request as ready for review July 11, 2023 15:57
@jessepeterson
Copy link
Member

i notice a few (most?) of the newline changes are removing newlines from text that is directly output. i.e. it’s for formatting/output style on a console. does your PR maintain that same formatting?

@jamesez
Copy link
Contributor Author

jamesez commented Jul 11, 2023

i notice a few (most?) of the newline changes are removing newlines from text that is directly output. i.e. it’s for formatting/output style on a console. does your PR maintain that same formatting?

I've made all but one out be md5 identical to previous - the previous output had a trailing whitespace on one line.

Copy link
Contributor

@korylprince korylprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also updated the Go versions for CI and the Dockerfile, and updated the CHANGELOG.

@korylprince korylprince merged commit 7a37154 into micromdm:main Jul 11, 2023
9 checks passed
@jamesez jamesez deleted the chore-tidy-for-go-1.20 branch July 12, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants