Support NDES with scepclient #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually I would write request.Body = ioutil.NopCloser(someReader) but this breaks
IIS because it doesnot support chunked Transfer-Encoding unless explicitly
configured.
Example sending ioutil.NopCloser(strings.NewReader("hello")) to a server:
POST / HTTP/1.1
Host: localhost:9000
Transfer-Encoding: chunked
Accept-Encoding: gzip
Content-Type: application/x-www-form-urlencoded
User-Agent: Go-http-client/1.1
5
hello
0
With this request, IIS responds with:
HTTP/1.1 200 OK
Content-Length: 0
Date: Sat, 08 Jul 2017 20:12:56 GMT
Server: Microsoft-IIS/10.0
X-Powered-By: ASP.NET
If the message is not a io.ReadCloser, then Content-Length is set:
POST / HTTP/1.1
Host: localhost:9000
Accept-Encoding: gzip
Content-Length: 5
Content-Type: application/x-www-form-urlencoded
User-Agent: Go-http-client/1.1
hello%
- check for failInfo if needed. - wrap errors. - implement fmt.Stringer for failInfo and messageType.
groob
force-pushed
the
ndes_compatible_client
branch
from
095f763
to
948cec0
Compare
use an md5 fingerprint to determinte the recipient of the pkcs7 message and return a chain starting with that cert. Sample for NDES server (2 is the fingerprint): 0 WINSRV-MSCEP-RA 7b6673d4e87eaf5a66d7772bb86f5c94 1 WINSRV-MSCEP-RA f10007498a27451802f67f4e6a0daaf1 2 WINSRV-CA 81c827d23daaf3b47399963267609b30
If the server returns a PENDING status, retry until SUCCESS or FAILURE.
groob
force-pushed
the
ndes_compatible_client
branch
from
f70925a
to
0f9a1a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring a bunch of related bugs to make scpeclient work with windows.