Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserting Observation keys and value should offer suggestions from the other cardinality bucket. #4046

Closed
osi opened this issue Aug 25, 2023 · 2 comments · Fixed by #4768
Closed

Comments

@osi
Copy link

osi commented Aug 25, 2023

Please describe the feature request.

When using #hasLowCardinalityKeyValue or #hasHighCardinalityKeyValue, if the key is not found, in addition to listing all the possible keys with the same cardinality, it should print the keys with the differing cardinality.

Rationale

There are two types of mistakes possible in writing an assertion:

  • Correct cardinality, wrong key name
  • Wrong cardinality, correct key name

The current error message only helps with the first case.

@marcingrzejszczak
Copy link
Contributor

Great idea! Are you willing to file a PR?

@izeye
Copy link
Contributor

izeye commented Feb 24, 2024

I created #4768 to try to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants