Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow onComplete before request in PipeliningServerHandler #10017

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Oct 24, 2023

It is legal for a reactive publisher to call onComplete immediately after subscribe, before data is requested. This could lead to a failure when such a publisher was queued for write.

Addresses #9677

It is legal for a reactive publisher to call onComplete immediately after subscribe, before data is requested. This could lead to a failure when such a publisher was queued for write.

Addresses #9677
@yawkat yawkat added the type: bug Something isn't working label Oct 24, 2023
@yawkat yawkat added this to the 4.1.11 milestone Oct 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo removed the request for review from timyates October 24, 2023 10:19
@yawkat yawkat merged commit f7bc0ad into 4.1.x Oct 24, 2023
10 checks passed
@yawkat yawkat deleted the complete-early branch October 24, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants