Reworked ability to disable initializing Slf4J #9185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altro3
force-pushed
the
fix_disable_log_2
branch
from
6140ca5
to
8671f41
Compare
|
The PR includes several breaking API changes which will have to be corrected first plus the tests are failing |
…ble_log_2 # Conflicts: # core/src/main/java/io/micronaut/core/io/scan/DefaultClassPathResourceLoader.java # inject/src/main/java/io/micronaut/context/env/AbstractPropertySourceLoader.java # inject/src/main/java/io/micronaut/context/env/PropertySourcePropertyResolver.java
|
@graemerocher Need to return methods |
altro3
force-pushed
the
fix_disable_log_2
branch
2 times, most recently
from
4ab68b2
to
1ec5466
Compare
|
@graemerocher tests fixed. Also fixed several checkstyle errors, doclint errors and fixed 2 tests for windows |
graemerocher
requested changes
May 2, 2023
inject/src/main/java/io/micronaut/context/env/PropertySourcePropertyResolver.java
Show resolved
Hide resolved
inject/src/main/java/io/micronaut/context/env/PropertySourcePropertyResolver.java
Show resolved
Hide resolved
graemerocher
approved these changes
May 3, 2023
sdelamo
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the previous solution didn't work because the static fields were still initialized regardless of usage.
This solution is much more efficient and works 100% because I tested it several times :). Now, if necessary, the logEnabled flag is set in the constructor and the logger is not static, but is created through the factory only if necessary. Otherwise, a dummy logger is created.
Thus, the code remains as it was and we have the opportunity to turn off the initialization of slf4j in micronaut-openapi.
This solution also corrects the names of loggers when inheriting. Now the child and parent methods use a single logger with the name of the child class (this cannot be done when you have a static logger)