Missing the ConsumerSeekAware interface

[guillermocalvo]

Added two new mechanisms to allow for immediate/deferred Kafka seek operations:

• New interface ConsumerSeekAware allows consumers to react when the set of partitions assigned to the consumer changes.

@KafkaListener
class Example implements ConsumerSeekAware {
    /* ... */
    @Override 
    public void onPartitionsAssigned(Collection<TopicPartition> partitions, KafkaSeeker seeker) {
        seeker.seekToBeginning(partitions).forEach(seeker::perform);
    }
}

• New interface KafkaSeekOperations can be injected into consumer methods so that seek operations can be performed when/if the method completes successfully.

@KafkaListener
class Example {
    static final TopicPartition TP = new TopicPartition("foo", 0);
    @Topic("foo")
    public void consume(String message, KafkaSeekOperations ops) {
        /* ... */
        ops.defer(ops.seekToEnd(TP));
    }
}

[sdelamo]

Add tests for the code samples in test-suite, test-suite-groovy and `test-suite-kotlin

[sdelamo]

@guillermocalvo I merged master into the branch but the test fails for me. can you investigate? Sorry 😬

[guillermocalvo]

@sdelamo

@guillermocalvo I merged master into the branch but the test fails for me. can you investigate? Sorry 😬

You removed MY_KAFKA.stop(), which allowed the tests to run in isolation. Do you really want that removed or, can we simply put it back?

[sdelamo]

@sdelamo

@guillermocalvo I merged master into the branch but the test fails for me. can you investigate? Sorry 😬

You removed MY_KAFKA.stop(), which allowed the tests to run in isolation. Do you really want that removed or, can we simply put it back?

ping @timyates 🖕. if possible it would be good to use the same Kafka instance for them.

[sdelamo]

You removed MY_KAFKA.stop(), which allowed the tests to run in isolation. Do you really want that removed or, can we simply put it back?

I removed it because MY_KAFKA property no longer exists since #824.

[sdelamo]

@wetted changed test-suite, test-suite-groovy and test-suite-kotlin to use Test Resources

#825

I have merged master into this branch and remove AbstractKafkaTest

However, there are failures in test-suite, test-suite-groovy and test-suite-kotlin.

[guillermocalvo]

@wetted changed test-suite, test-suite-groovy and test-suite-kotlin to use Test Resources

#825

I have merged master into this branch and remove AbstractKafkaTest

However, there are failures in test-suite, test-suite-groovy and test-suite-kotlin.

@sdelamo Those classes were there to illustrate section Running Kafka while testing and developing of the guide.

[wetted]

@sdelamo

As @guillermocalvo notes AbstractKafkaTest, and MyTest which uses it should remain in test-suite-* for this part of the guide. https://micronaut-projects.github.io/micronaut-kafka/latest/guide/#kafkaDockerized

But AbstractKafkaTest should be not used for anything else because I'm now using test-resources for everything else, as recommended by that same section of the guide.

see #826 as an example

I am updating other sections in the guide to do the same (i.e. multi-lang snippets with test-resources tests).

[guillermocalvo]

@sdelamo I updated the tests to use test-resources. BTW SonarCloud is in the wrong again.

[sdelamo]

ping @dstepanov

Done

[dstepanov]

I would use just nullable boolean

[guillermocalvo]

Ok so I did what you requested but then Sonar was complaining about "null should not be returned from a Boolean method" and I had to revert the changes.

[dstepanov]

Ok

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

94.6% Coverage
0.0% Duplication