Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-language documentation for Injecting Kafka Producer Beans example #826

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Aug 18, 2023

No description provided.

@wetted wetted requested a review from sdelamo August 18, 2023 17:16
@wetted wetted self-assigned this Aug 18, 2023
@wetted wetted requested a review from timyates August 18, 2023 17:23
@wetted
Copy link
Contributor Author

wetted commented Aug 18, 2023

@timyates thanks for helping

Copy link
Member

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap in try-with-resouces to close the context after the test?

…ct/BookSenderTest.java

Co-authored-by: Tim Yates <tim.yates@gmail.com>
Copy link
Member

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests should assert something 😎

@wetted wetted requested a review from timyates August 21, 2023 16:44
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wetted wetted merged commit ce4c300 into master Aug 21, 2023
8 checks passed
@wetted wetted deleted the docs-inject-producer-beans branch August 21, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants