-
Notifications
You must be signed in to change notification settings - Fork 124
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: add request to jwt claims validator
Close: #381 remove default from TokenValidator revert as before leave implementation in validate(String) don't override request don't override request remove unused imports remove unused imports you have to opt-in to pass httprequest make it configurable pass-http-request add boolean value remove ugly pass http request
- Loading branch information
Showing
11 changed files
with
323 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
...onaut/security/token/jwt/validator/JwtClaimsValidatorRequestNotPassedByDefaultSpec.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| package io.micronaut.security.token.jwt.validator | ||
|
|
||
| import edu.umd.cs.findbugs.annotations.NonNull | ||
| import edu.umd.cs.findbugs.annotations.Nullable | ||
| import io.micronaut.context.annotation.Requires | ||
| import io.micronaut.http.HttpHeaders | ||
| import io.micronaut.http.HttpRequest | ||
| import io.micronaut.http.HttpResponse | ||
| import io.micronaut.http.HttpStatus | ||
| import io.micronaut.http.MediaType | ||
| import io.micronaut.http.annotation.Controller | ||
| import io.micronaut.http.annotation.Get | ||
| import io.micronaut.http.annotation.Produces | ||
| import io.micronaut.security.annotation.Secured | ||
| import io.micronaut.security.authentication.AuthenticationException | ||
| import io.micronaut.security.authentication.AuthenticationFailed | ||
| import io.micronaut.security.authentication.AuthenticationProvider | ||
| import io.micronaut.security.authentication.AuthenticationRequest | ||
| import io.micronaut.security.authentication.AuthenticationResponse | ||
| import io.micronaut.security.authentication.UserDetails | ||
| import io.micronaut.security.authentication.UsernamePasswordCredentials | ||
| import io.micronaut.security.rules.SecurityRule | ||
| import io.micronaut.security.token.jwt.generator.claims.JwtClaims | ||
| import io.micronaut.security.token.jwt.render.BearerAccessRefreshToken | ||
| import io.micronaut.testutils.EmbeddedServerSpecification | ||
| import io.reactivex.BackpressureStrategy | ||
| import io.reactivex.Flowable | ||
| import org.reactivestreams.Publisher | ||
|
|
||
| import javax.inject.Singleton | ||
| import java.security.Principal | ||
|
|
||
| class JwtClaimsValidatorRequestNotPassedByDefaultSpec extends EmbeddedServerSpecification { | ||
| @Override | ||
| String getSpecName() { | ||
| 'JwtClaimsValidatorRequestNotPassedByDefaultSpec' | ||
| } | ||
|
|
||
| @Override | ||
| Map<String, Object> getConfiguration() { | ||
| super.configuration + [ | ||
| 'micronaut.security.token.jwt.signatures.secret.generator.secret': 'pleaseChangeThisSecretForANewOne', | ||
| 'micronaut.security.authentication' : 'bearer', | ||
| ] | ||
| } | ||
|
|
||
| def "by default JwtClaimsValidator which expects request is not invoked"() { | ||
| when: | ||
| UsernamePasswordCredentials creds = new UsernamePasswordCredentials('user', 'password') | ||
| HttpResponse rsp = client.exchange(HttpRequest.POST('/login', creds), BearerAccessRefreshToken) | ||
|
|
||
| then: | ||
| rsp.status() == HttpStatus.OK | ||
| rsp.body().accessToken | ||
|
|
||
| when: | ||
| final String accessToken = rsp.body().accessToken | ||
| HttpRequest request = HttpRequest.GET("/echo/user") | ||
| .accept(MediaType.TEXT_PLAIN) | ||
| .header(HttpHeaders.AUTHORIZATION, "Bearer $accessToken") | ||
| client.exchange(request) | ||
|
|
||
| then: // no 401 is thrown because GenericJwtClaimsValidator::validate is invoked claims, null and the HttpRequestClaimsValidator returns true | ||
| noExceptionThrown() | ||
| } | ||
|
|
||
| @Requires(property = 'spec.name', value = 'JwtClaimsValidatorRequestNotPassedByDefaultSpec') | ||
| @Singleton | ||
| static class HttpRequestClaimsValidator implements GenericJwtClaimsValidator { | ||
|
|
||
| @Override | ||
| boolean validate(JwtClaims claims) { | ||
| false | ||
| } | ||
|
|
||
| @Override | ||
| boolean validate(@NonNull JwtClaims claims, @Nullable HttpRequest<?> request) { | ||
| request == null | ||
| } | ||
| } | ||
|
|
||
| @Controller("/echo/user") | ||
| @Requires(property = 'spec.name', value = 'JwtClaimsValidatorRequestNotPassedByDefaultSpec') | ||
| static class EchoController { | ||
|
|
||
| @Secured(SecurityRule.IS_AUTHENTICATED) | ||
| @Produces(MediaType.TEXT_PLAIN) | ||
| @Get | ||
| String index(Principal principal) { | ||
| principal.name | ||
| } | ||
| } | ||
|
|
||
| @Singleton | ||
| @Requires(property = 'spec.name', value = 'JwtClaimsValidatorRequestNotPassedByDefaultSpec') | ||
| static class AuthenticationProviderUserPassword implements AuthenticationProvider { | ||
|
|
||
| @Override | ||
| Publisher<AuthenticationResponse> authenticate(HttpRequest<?> httpRequest, AuthenticationRequest<?, ?> authenticationRequest) { | ||
| Flowable.create({ emitter -> | ||
| if (authenticationRequest.identity == 'user' && authenticationRequest.secret == 'password') { | ||
| emitter.onNext(new UserDetails('user', [])) | ||
| emitter.onComplete() | ||
| } else { | ||
| emitter.onError(new AuthenticationException(new AuthenticationFailed())) | ||
| } | ||
|
|
||
| }, BackpressureStrategy.ERROR) | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.