Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add request to jwt claims validator #396

Merged
merged 1 commit into from Sep 25, 2020
Merged

refactor: add request to jwt claims validator #396

merged 1 commit into from Sep 25, 2020

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Sep 24, 2020

Close: #381

@sdelamo sdelamo self-assigned this Sep 24, 2020
@alvarosanchez
Copy link
Member

I see the request being exposed as a parameter, but don't see where the request is obtained and passed to any of those methods

@sdelamo
Copy link
Contributor Author

sdelamo commented Sep 24, 2020

@alvarosanchez it is passed in TokenAuthenticationFetcher

.flatMap(tokenValidator -> tokenValidator.validateToken(tokenValue, request))

@sdelamo sdelamo force-pushed the add-request-to-jwt-claims-validator branch from 9da3fe0 to 781727b Compare September 24, 2020 18:05
@sdelamo sdelamo removed the request for review from alvarosanchez September 24, 2020 18:05
@sdelamo sdelamo force-pushed the add-request-to-jwt-claims-validator branch from 781727b to 60292a7 Compare September 24, 2020 18:06
@jameskleeh jameskleeh merged commit 797decf into master Sep 25, 2020
@jameskleeh jameskleeh deleted the add-request-to-jwt-claims-validator branch September 25, 2020 14:27
sdelamo added a commit that referenced this pull request Sep 26, 2020
@sdelamo
refactor: add request to jwt claims validator (#396)
7635eb7 
Close: #381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosanchez alvarosanchez alvarosanchez approved these changes

@jameskleeh jameskleeh Awaiting requested review from jameskleeh

Assignees

@sdelamo sdelamo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HttpRequest as a method parameter in JWTClaimsValidator
3 participants
@sdelamo @alvarosanchez @jameskleeh