Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete neo4j test harness dependency in favor of Testcontainers Neo4j #2434

Open
wants to merge 4 commits into
base: 5.0.x
Choose a base branch
from

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Apr 10, 2024

closes #2390

…ers Neo4j. Support for the former was removed from micronaut-neo4j for Micronaut Framework 5. [skip ci]
@wetted wetted self-assigned this Apr 10, 2024
@wetted wetted linked an issue Apr 10, 2024 that may be closed by this pull request
@wetted
Copy link
Contributor Author

wetted commented Apr 10, 2024

WIP: This needs be changed to use the ContributingTestContainerDependency after branch 4.4.x is merged into 5.0.x. See #2413

@sdelamo
Copy link
Contributor

sdelamo commented Apr 19, 2024

I think 4.4.x is merged into 5.

# Conflicts:
#	starter-core/src/main/java/io/micronaut/starter/feature/database/TestContainers.java
@wetted wetted marked this pull request as ready for review April 22, 2024 15:47
@wetted wetted added the type: breaking Introduces a breaking change label Apr 22, 2024
@wetted
Copy link
Contributor Author

wetted commented Apr 22, 2024

CI failure relates to the JobRunr feature and is broken on 5.0.x branch as well. I'm investigating.

Edit: this is breaking on the MicronautCommunityFeature/MicronautCommunityFeatureValidator logic. I'll fix that on a separate PR. FYI @sdelamo

@wetted
Copy link
Contributor Author

wetted commented Apr 23, 2024

Pending fix for broken CI on #2462

@wetted wetted removed their assignment Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Remove neo4j-harness from neo4j feature for Micronaut 5
2 participants