add tzinfo constructor (fixes #319) #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #319 for me nicely, thx! |
stinos
reviewed
Mar 18, 2020
| @@ -914,6 +914,11 @@ class tzinfo: | |||
| Subclasses must override the name(), utcoffset() and dst() methods. | |||
| """ | |||
| __slots__ = () | |||
|
|
|||
| def __new__(cls): | |||
There was a problem hiding this comment.
If you run the test suite this will fail at some point because more arguments are passed. I'd suggest you go with
def __new__(cls, *args, **kwargs):
return object.__new__(cls)
|
@dpgeorge this is low-hanging fruit to get more CPython compatibility. Even though with a fix the test suite doesn't pass completely (on CPython nor on MicroPython) can we this fix in so it's at least possible to import datetime? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the following
datetimeerror: