Skip to content

Commit

Permalink
windows/Makefile: Add .exe extension to executables name.
Browse files Browse the repository at this point in the history
Uses the same logic applied in 5b57ae9
to determine when to add .exe.

See related: #3310, #3361, #3370, #4143, #5727.
  • Loading branch information
btongminh authored and dpgeorge committed Jul 8, 2021
1 parent e10a044 commit 3d9af87
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
5 changes: 1 addition & 4 deletions ports/windows/.appveyor.yml
Expand Up @@ -63,10 +63,7 @@ after_test:
throw "$env:MSYSTEM build exited with code $LASTEXITCODE"
}
cd (Join-Path $env:APPVEYOR_BUILD_FOLDER 'mpy-cross')
# Building of mpy-cross hasn't been fixed across all possible windows/WSL/...
# variations and the STRIP step tries to strip mpy-cross whereas that should be
# mpy-cross.exe. Workaround for now by skipping actual strip and size commands.
C:\msys64\usr\bin\bash.exe -l -c "make -B -j4 V=1 STRIP=echo SIZE=echo"
C:\msys64\usr\bin\bash.exe -l -c "make -B -j4 V=1"
if ($LASTEXITCODE -ne 0) {
throw "$env:MSYSTEM mpy_cross build exited with code $LASTEXITCODE"
}
Expand Down
2 changes: 1 addition & 1 deletion ports/windows/Makefile
Expand Up @@ -2,7 +2,7 @@ include ../../py/mkenv.mk
-include mpconfigport.mk

# define main target
PROG = micropython.exe
PROG = micropython

# qstr definitions (must come before including py.mk)
QSTR_DEFS = ../unix/qstrdefsport.h
Expand Down
11 changes: 9 additions & 2 deletions py/mkrules.mk
Expand Up @@ -178,6 +178,13 @@ endif
ifneq ($(PROG),)
# Build a standalone executable (unix does this)

# The executable should have an .exe extension for builds targetting 'pure'
# Windows, i.e. msvc or mingw builds, but not when using msys or cygwin's gcc.
COMPILER_TARGET := $(shell $(CC) -dumpmachine)
ifneq (,$(findstring mingw,$(COMPILER_TARGET)))
PROG := $(PROG).exe
endif

all: $(PROG)

$(PROG): $(OBJ)
Expand All @@ -186,9 +193,9 @@ $(PROG): $(OBJ)
# we may want to compile using Thumb, but link with non-Thumb libc.
$(Q)$(CC) -o $@ $^ $(LIB) $(LDFLAGS)
ifndef DEBUG
$(Q)$(STRIP) $(STRIPFLAGS_EXTRA) $(PROG)
$(Q)$(STRIP) $(STRIPFLAGS_EXTRA) $@
endif
$(Q)$(SIZE) $$(find $(BUILD) -path "$(BUILD)/build/frozen*.o") $(PROG)
$(Q)$(SIZE) $$(find $(BUILD) -path "$(BUILD)/build/frozen*.o") $@

clean: clean-prog
clean-prog:
Expand Down

0 comments on commit 3d9af87

Please sign in to comment.