Skip to content

Commit

Permalink
examples: Mark asm, pio, etc. as noqa: F821 (undefined-name).
Browse files Browse the repository at this point in the history
These files all use decorators (@asm_thumb, @asm_pio) that add names to the
function scope, that the linter cannot see.

It's useful to clear them in the file not in pyproject.toml as example code
will be copied and adapted elsewhere, and those developers may also use
Ruff (we hope!)

Signed-off-by: Angus Gratton <angus@redyak.com.au>
  • Loading branch information
projectgus authored and dpgeorge committed Aug 16, 2023
1 parent 00855ee commit 861fbf6
Show file tree
Hide file tree
Showing 13 changed files with 31 additions and 0 deletions.
4 changes: 4 additions & 0 deletions examples/asmled.py
@@ -1,5 +1,9 @@
# flash LED #1 using inline assembler
# this version is overly verbose and uses word stores
#
# ruff: noqa: F821 - @asm_thumb decorator adds names to function scope


@micropython.asm_thumb
def flash_led(r0):
movw(r1, (stm.GPIOA + stm.GPIO_BSRRL) & 0xFFFF)
Expand Down
3 changes: 3 additions & 0 deletions examples/asmsum.py
@@ -1,3 +1,6 @@
# ruff: noqa: F821 - @asm_thumb decorator adds names to function scope


@micropython.asm_thumb
def asm_sum_words(r0, r1):
# r0 = len
Expand Down
4 changes: 4 additions & 0 deletions examples/natmod/btree/btree_py.py
@@ -1,3 +1,7 @@
# Implemented in Python to support keyword arguments

# ruff: noqa: F821 - this file is evaluated with C-defined names in scope


def open(stream, *, flags=0, cachesize=0, pagesize=0, minkeypage=0):
return _open(stream, flags, cachesize, pagesize, minkeypage)
2 changes: 2 additions & 0 deletions examples/natmod/features2/test.py
@@ -1,5 +1,7 @@
# This Python code will be merged with the C code in main.c

# ruff: noqa: F821 - this file is evaluated with C-defined names in scope

import array


Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_1hz.py
@@ -1,6 +1,8 @@
# Example using PIO to blink an LED and raise an IRQ at 1Hz.
# Note: this does not work on Pico W because it uses Pin(25) for LED output.

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

import time
from machine import Pin
import rp2
Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_exec.py
Expand Up @@ -5,6 +5,8 @@
# - using set_init and set_base
# - using StateMachine.exec

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

import time
from machine import Pin
import rp2
Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_pinchange.py
Expand Up @@ -8,6 +8,8 @@
# - setting an irq handler for a StateMachine
# - instantiating 2x StateMachine's with the same program and different pins

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

import time
from machine import Pin
import rp2
Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_pwm.py
@@ -1,5 +1,7 @@
# Example of using PIO for PWM, and fading the brightness of an LED

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

from machine import Pin
from rp2 import PIO, StateMachine, asm_pio
from time import sleep
Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_uart_rx.py
Expand Up @@ -8,6 +8,8 @@
# - PIO irq handler
# - using the second core via _thread

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

import _thread
from machine import Pin, UART
from rp2 import PIO, StateMachine, asm_pio
Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_uart_tx.py
@@ -1,5 +1,7 @@
# Example using PIO to create a UART TX interface

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

from machine import Pin
from rp2 import PIO, StateMachine, asm_pio

Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pio_ws2812.py
@@ -1,5 +1,7 @@
# Example using PIO to drive a set of WS2812 LEDs.

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

import array, time
from machine import Pin
import rp2
Expand Down
2 changes: 2 additions & 0 deletions examples/rp2/pwm_fade.py
@@ -1,6 +1,8 @@
# Example using PWM to fade an LED.
# Note: this does not work on Pico W because it uses Pin(25) for LED output.

# ruff: noqa: F821 - @asm_pio decorator adds names to function scope

import time
from machine import Pin, PWM

Expand Down
2 changes: 2 additions & 0 deletions ports/qemu-arm/test-frzmpy/frozen_asm.py
@@ -1,5 +1,7 @@
# Test freezing inline-asm code.

# ruff: noqa: F821 - @asm_thumb decorator adds names to function scope

import micropython


Expand Down

0 comments on commit 861fbf6

Please sign in to comment.