Skip to content

Commit

Permalink
windows/msvc: Fix qstr generation dependency.
Browse files Browse the repository at this point in the history
The mpversion.h file must exist before py/ source can be preprocessed,
but this went unnoticed because micropython.vcxproj always calls
MakeVersionHdr before MakeQstrDefs.
  • Loading branch information
stinos authored and dpgeorge committed Feb 1, 2023
1 parent 65941ea commit e145318
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ports/windows/msvc/genhdr.targets
Expand Up @@ -62,7 +62,7 @@ using(var outFile = System.IO.File.CreateText(OutputFile)) {
</ItemGroup>

<!-- Preprocess changed files, concatenate and feed into makeqstrdefs.py split/cat-->
<Target Name="MakeQstrDefs" DependsOnTargets="MakeDestDir" Inputs="@(ClCompile);@(QstrDependencies)" Outputs="$(QstrDefsCollected)">
<Target Name="MakeQstrDefs" DependsOnTargets="MakeDestDir;MakeVersionHdr" Inputs="@(ClCompile);@(QstrDependencies)" Outputs="$(QstrDefsCollected)">
<ItemGroup>
<PyIncDirs Include="$(PyIncDirs)"/>
<PreProcDefs Include="%(ClCompile.PreProcessorDefinitions);NO_QSTR"/>
Expand Down

0 comments on commit e145318

Please sign in to comment.