New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lwip git host down, perhaps make a mirror? #5356
Comments
See also #4429 for past issues with the lwip URL. |
Yes I guess this makes sense. It is quite limiting not being able to develop when a site goes down. All other submodules link to a GitHub URL. Of course that means we have a big dependence on GitHub being up, but it has a history of being pretty stable. And we have to host the code somewhere and rely on something, so GitHub seems a sensible choice. Probably someone else already cloned lwip to GitHub and we can just link to that? |
I had a quick look and didn't find any github lwip's that looked particularly "official", most notably the stmduino one is modified, the other one that came up hadn't brought across the tags. |
Actually, here's a couple of candidates: edit: nope both out of date |
Seems like there is an official github mirror now for LWIP repo: https://github.com/lwip-tcpip/lwip Maintainers seems to be same people as in savannah repo. Could we perhaps switch the link for lwip submodule to use github repo now? |
Yes, sounds good! |
See #7250 |
Great. Thank you for prompt reply. I too hope it's more reliable as well! |
Done in 43e7e5f |
Came here to suggest a switch to a git mirror, glad to see it's in hand! I'm building against the latest released MicroPython (v1.15) and, predictably:
I guess I could hotfix the .gitmodules with some |
Pulls down the upstream patch from micropython/micropython#7250 and applies it. Issue discussed here: micropython/micropython#5356
Pulls down the upstream patch from micropython/micropython#7250 and applies it. Issue discussed here: micropython/micropython#5356
Yes it should be out within the coming week. |
This needs thorough testing before it's merged, as we tried and reverted this once before (micropython#5341 and micropython#5356). I think that besides checking for tinyusb having "something to do", the fact that `port_interrupt_after_ticks` and `port_disable_tick` weren't implemented that was causing a secondary problem. I've tested this on a pico w over reboot-cycles and ctrl-c-cycles, with and without drive automounting, with and without serial repl open, and on a power-only connection. I didn't notice the problem reported in micropython#5356 after merely implementing port_idle_until_interrupt; but I did notice that sleeps in general would take over-long until "something" (like writing to the USB drive) happened; I think "something" was probably calling port_enable_tick(). When this problem was happening, sleeps would take a lot longer; for instance, `sleep(.001)` would take about 1/20s and `sleep(.1)` would take about 1/7s.
As I write this, https://git.savannah.gnu.org/ is down as it surprisingly often is.
The
lwip
project is hosted here, so is needed to clone the submodule.The host being down means CI builds of micropython fail fairly regularly
@dpgeorge would you consider mirroring the lwip project here in your github group to increase the stability of access?
The text was updated successfully, but these errors were encountered: