ports/RTC: Attempt to reduce the inconsistencies between the port's RTC implementation. #10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-hh
force-pushed
the
ports_rtc
branch
2 times, most recently
from
f2a106f
to
0c50a73
Compare
Such that it matches the implementation and the documentation of the machine.RTC class. Signed-off-by: robert-hh <robert@hammelrath.com>
And show the port availability of rtc.now() in the documentation. Signed-off-by: robert-hh <robert@hammelrath.com>
- make the argument ordering of rtc.init() the same for the ports WiPy, ESP32 and MIMXRT. The WiPy argument ordering is used. - drop rtc.init() from the samd port. - Document the availability and the differing semantics for the STM32 and renesas-ra port. Signed-off-by: robert-hh <robert@hammelrath.com>
|
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the issue #10578 and #5553 and other discussions about the topic. It consists of the commits:
docs/quickref: Fix the documentation of rtc.datetime(), which makes the documentation of rtc.datetime() consistent to the implementation for all ports.mimxrt/machine_rtc.c: Drop rtc.now()Keep it at the WiPy port for legacy,ports/RTC: Rework the availability and interface of rtc.init(), which drops rtc.init() from the SAMD port and makes it consistent to the documentation and the WiPy port for the ports ESP32 and MIMXRT. But rtc.init() could as well be dropped for the latter ones and just kept for WiPy.