Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Add DAC deinit() method. #10852

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ESP32: Add DAC deinit() method. #10852

wants to merge 1 commit into from

Conversation

IhorNehrutsa
Copy link
Contributor

Also, add machine_dac_deinit_all() which is called by Ctrl-D soft reboot.

@IhorNehrutsa IhorNehrutsa mentioned this pull request Feb 25, 2023
Closed
@IhorNehrutsa
Copy link
Contributor Author

@dpgeorge
How can I set the "port-esp32" label for this pool request?

@robert-hh
Copy link
Contributor

robert-hh commented Mar 12, 2023 •
edited
Loading

There should be a section labelled "Labels" with a setup-symbol at the right side of the screen, when you call up your pull request.
grafik

@IhorNehrutsa
Copy link
Contributor Author

Thanks, Robert.
But nothing!
image

@IhorNehrutsa IhorNehrutsa changed the title ESP32: Add DAC.deinit() method. ESP32: Add DAC deinit() method. Mar 12, 2023
@IhorNehrutsa
Copy link
Contributor Author

IhorNehrutsa commented Jul 21, 2023 •
edited
Loading

@dpgeorge
May add to the https://github.com/micropython/micropython/milestone/4 ?

@IhorNehrutsa IhorNehrutsa force-pushed the dac_deinit branch 2 times, most recently from fe5af5e to cf66fd1 Compare September 4, 2023 13:18
@IhorNehrutsa
esp32/DAC: Add DAC deinit() method.
eaf6dac 
esp32/DAC: Add DAC deinit() method.

Signed-off-by: Ihor Nehrutsa <IhorNehrutsa@gmail.com>
@Gadgetoid Gadgetoid mentioned this pull request Feb 29, 2024
Merged
@projectgus
Copy link
Contributor

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IhorNehrutsa @robert-hh @projectgus