Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ports/esp32/boards: Add Deneyap Boards. #11169

Closed
wants to merge 1 commit into from
Closed

ports/esp32/boards: Add Deneyap Boards. #11169

wants to merge 1 commit into from

Conversation

ozgurbostan
Copy link

@ozgurbostan ozgurbostan commented Mar 31, 2023 •
edited

  • Deneyap Kart
  • Deneyap Kart 1A
  • Deneyap Kart 1A v2
  • Deneyap Kart G
  • Deneyap Kart Mini
  • Deneyap Kart Mini v2

@DogushC
Copy link

DogushC commented Apr 4, 2023 •
edited

Hi @dpgeorge ,

We are waiting for the review process both for this and that PR. Could you please make a review when you are available?

@ozgurbostan
Copy link
Author

ozgurbostan commented Apr 14, 2023 •
edited

Dear @dpgeorge,

Our PR has not been merged, I wonder whether there is something that we need to do?

@DogushC
Copy link

DogushC commented Jun 15, 2023

Hi @dpgeorge, could you merge the PR?

@ozgurbostan
Copy link
Author

ozgurbostan commented Jul 8, 2023 •
edited

Hi @dpgeorge,

Any problem with the PR? It's been 3 months since any progress. Any update you need, let me know please.

@ozgurbostan
Copy link
Author

Hi @dpgeorge,

Any progress? It is 6 months and still no response, even no reply for the enquiries.

Could you please tell us what is wrong or else accept our pull request?

mattytrentini
mattytrentini reviewed Oct 3, 2023
View reviewed changes
Copy link
Sponsor Contributor

@mattytrentini mattytrentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments to DENEYAP_KART also apply to the other boards.

ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.md Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/modules/deneyapkart.py Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
ports/esp32/boards/DENEYAP_KART/board.json Show resolved Hide resolved
@pxsty0
Copy link

pxsty0 commented Apr 30, 2024 •
edited

Hello , what do we need to do to add the cards?

@pxsty0
Copy link

pxsty0 commented May 1, 2024

@mattytrentini

@ozgurbostan ozgurbostan closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattytrentini mattytrentini mattytrentini left review comments

Assignees
No one assigned
Labels
board-definition port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ozgurbostan @DogushC @pxsty0 @mattytrentini @dpgeorge