Minor Zephyr port features #11360
Merged
Minor Zephyr port features #11360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadonk
force-pushed
the
minor-zephyr-features
branch
4 times, most recently
from
880888f
to
26bfc5e
Compare
dpgeorge
reviewed
May 9, 2023
ports/zephyr/modusocket.c
Outdated
| } | ||
|
|
||
| if (recv_len == 0) { | ||
| return mp_const_empty_bytes; |
There was a problem hiding this comment.
I think in this case it should still return a tuple, like (b"", <addr>).
There was a problem hiding this comment.
I made this changed during merge.
|
Thanks for the contribution! Apart from the above comment, these changes look good. |
MaureenHelm
approved these changes
May 9, 2023
|
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
dpgeorge
force-pushed
the
minor-zephyr-features
branch
from
26bfc5e
to
c211c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recvfromfunction useful for broadcast UDP messagesmdns_service: add ability to broadcast mdns advertisements