pyboard changes needed for rshell #1264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -125,7 +127,7 @@ def eval(self, expression): | |||
| ret = ret.strip() | |||
| return ret | |||
|
|
|||
| def exec(self, command): | |||
| def exec(self, command, data_consumer=None): | |||
There was a problem hiding this comment.
Did you mean to pass data_consumer to exec_raw on the following line?
There was a problem hiding this comment.
Hmm. I don't use the data_consumer, so that line could remain the same as it was before.
dhylands
force-pushed
the
pyboard-rshell-changes
branch
from
3ac7f4f
to
f47c4b4
Compare
|
I updated the PR so that exec remains unmodified. |
|
Merged in 97ce883. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change I needed to make to pyboard.py in order to make rshell.py work.