ports/esp32: pwm: prevent duty glitch on init #12650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new channel was assigned, configure_channel would seet the duty
to 50% before resetting to the actual user specified duty. This results
in unintentional glitches.
Example code
```
p1 = machine.PWM(self.pin1, self.pwm_freq, duty_u16=0)
```
This would brieflt glitch a pwm motor driver when it's created, instead of
leaving it at duty=0 as intended.
Instead, we calculate the duty into native units first, and apply it
separately in a second step where needed.
Signed-off-by: Karl Palsson <karlp@tweak.au>
karlp
force-pushed
the
karl-pwm-init-fix1
branch
from
e321c5a
to
26d4ebe
Compare
|
Yes, I discovered this while testing out #10854. This is much less intrusive, doesn't involve other exernal libs, and given the impact of it, seemed worthy of submitting on it's own, rather than the rest of the "consistency" fixes that old PR attempts to address. |
karlp
added a commit
to karlp/helloween2
that referenced
this pull request
Oct 11, 2023
See micropython/micropython#12650 It's not _critical_ but it's nice to not glitch the motor when you are trying to init the pins.
|
This is an automated heads-up that we've just merged a Pull Request See #13763 A search suggests this PR might apply the STATIC macro to some C code. If it Although this is an automated message, feel free to @-reply to me directly if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new channel was assigned, configure_channel would seet the duty to 50% before resetting to the actual user specified duty. This results in unintentional glitches.
Example code
This would brieflt glitch a pwm motor driver when it's created, instead of leaving it at duty=0 as intended.
Instead, we calculate the duty into native units first, and apply it separately in a second step where needed.
I'm not entirely in love with the split setters, but it made for the least intrusive diffs, to clearly show the problem.