Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py/mkrules, esp32: Use better build settings for ESP32-C3. #12839

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

agatti
Copy link
Contributor

@agatti agatti commented Oct 31, 2023

ESP32-C3 is not Xtensa-based, so build settings are now tailored a bit better following that fact. ESP-IDF 5.x already adds architecture-specific modules by itself so there is no need to specify either the xtensa or the riscv module in the build settings.

@github-actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #12839 (29ec32a) into master (4cffa84) will not change coverage.
The diff coverage is n/a.

❗ Current head 29ec32a differs from pull request most recent head 95ce61d. Consider uploading reports for the commit 95ce61d to get more accurate results

@@           Coverage Diff           @@
##           master   #12839   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         158      158           
  Lines       20973    20973           
=======================================
  Hits        20637    20637           
  Misses        336      336           

ESP32-C3 is not Xtensa-based, so build settings are now tailored a bit
better following that fact.  ESP-IDF 5.x already adds architecture-specific
modules by itself so there is no need to specify either the `xtensa` or the
`riscv` module in the build settings.

Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
@dpgeorge dpgeorge merged commit 95ce61d into micropython:master Nov 1, 2023
36 of 38 checks passed
@dpgeorge
Copy link
Member

dpgeorge commented Nov 1, 2023

Thanks for the patch.

@agatti agatti deleted the esp32-xtensa-riscv branch November 1, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants