tools/tinytest-codegen: Ensure consistent tests order. #12906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the the generated header file contains tests appearing in a predictable order, conforming to `tests/run-tests.py`'s behaviour. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
|
Code size report: |
Codecov Report
@@ Coverage Diff @@
## master #12906 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 158 158
Lines 20972 20972
=======================================
Hits 20636 20636
Misses 336 336 |
dpgeorge
reviewed
Nov 7, 2023
| for group in sorted(test_dirs): | ||
| tests += [ | ||
| test for test in sorted(glob("{}/*.py".format(group))) if test not in exclude_tests | ||
| ] |
There was a problem hiding this comment.
Wouldn't it be a lot simpler to just do tests.sort() after this for loop? Then there's no need to flatten anything.
There was a problem hiding this comment.
@agatti any thought about using sort() to keep this simple?
There was a problem hiding this comment.
Apologies for the delay, this fell off my radar. The reason for the list flattening was to prevent potential user error, as it was not obvious the tests exclusion list is a set and not an array of sorts.
If that's not a concern I can sort the final list without pre-flattening the input as you suggest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the the generated header file contains tests appearing in a predictable order, conforming to
tests/run-tests.py's behaviour.Suggested in #12853 (comment).