-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODECONVENTIONS.md: added documentation on documenting code. #1322
Conversation
|
||
// This function will always recurse indefinately and is only used to show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ should be indefinitely
Looks good to me. |
Isn't this obsolete now:
? |
Thanks for the spelling suggestions @pfalcon. I did an @danicampora it does seem to be outdated from other header files I've looked at, but I don't know. I could remove it in this PR if people want it removed. |
That's how I do it ;-)
Let's see what others think. |
- In general, there should not be lengthy or unnecessary comments. If something | ||
may be confusing to new contributors or people unfamiliar with computer | ||
science, it is fine to use a few key words and a link to a wikipedia article | ||
or a wiki page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to be picky on such a trivial thing, but the philosophy of what you've written here goes against itself: each point is an embellishment of the previous one! It would be enough to say "be concise". If you want to say more than that then "be concise and only write comments for things that are not obvious" would be pretty good.
Yes the stuff about Plan 9 headers is now obsolete, but it should be removed in a separate patch. |
Header conventions are addressed in 2474c2a |
Merged in f64e080. |
completes #1235