esp8266: Move scan() from esp module to network #1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owens-bill
changed the title
|
Looks good, will merge when when time permits. Doing it at this pace - one function at time, is just right, thanks @owens-bill ! |
|
+1 from me. [Note that the debug printf in the scan callback is removed, but I'm ok with that.] |
I figured that if I left that line in, there was at least a 50/50 chance that someone would say, "Why didn't you remove that old commented-out debug printf?" ;) |
In some cases they are not "old" but are in fact used semi-regularly. This case though is probably not needed anymore so good call removing it :) |
|
Generally, it's better to avoid any other changes when performing a code move. Merged, thanks. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Nov 14, 2018
Clear Trellis NeoPixels on board reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the suggestion by @pfalcon on PR# 1325, moving the scan method from esp to network. This PR does not include any new code, nor the constants for the various authentication modes.