ports/esp32: Make LAN.active(bool) idempotent. #15101
Open
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvis-epx
changed the title
Signed-off-by: Elvis Pfutzenreuter <epxx@epxx.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not raise an exception when LAN.active(False) is called but LAN is already inactive, or LAN.active(True) is called but LAN is already active.
Aligns this LAN API with with WLAN.active(bool), which is already idempotent.
Within ESP-IDF, it can be seen at [1] and [2] that esp_eth_start() and esp_eth_stop() return ESP_ERR_INVALID_STATE only when the state contradicts the intention, not for any actual error.
[1] https://github.com/espressif/esp-idf/blob/master/components/esp_eth/src/esp_eth.c#L278
[2] https://github.com/espressif/esp-idf/blob/master/components/esp_eth/src/esp_eth.c#L301