tests/io: Add tests for sleep_ms/us(), ticks_ms/us/diff(). #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpgeorge , @danicampora : Not sure which subdir this test should belong. |
Simple smoke tests, mostly for coverage.
pfalcon
force-pushed
the
sleep_ms-test
branch
from
23338ea
to
a1575de
Compare
|
Probably need a new directory, eg tests/pymod? Or tests/portmod (since it will hold tests for modules that are implemented per-port). But, if we don't want to add a new subdir just yet, and wait to see what other modules we get, I'd rather put this in extmod than io. |
|
Ok, put them in extmod with note: "Added to extmod based on the fact |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Feb 8, 2019
…or_overflow Check sequence multiply for length overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple smoke tests, mostly for coverage.