Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: Replace <zephyr/zephyr.h> with <zephyr/kernel.h>. #15291

Closed
wants to merge 1 commit into from

Conversation

danicampora
Copy link
Member

Also replace deprecated macro (FLASH_AREA_LABEL_EXISTS) that was causing the pre-processor to fail. This is all required to be compatible with newer releases of Zephyr (at least up to V3.6.0)

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (d7d77d9) to head (39af74a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15291   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         161      161           
  Lines       21204    21204           
=======================================
  Hits        20870    20870           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 16, 2024

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

@robert-hh
Copy link
Contributor

Hi Daniel. Good to see you back.

@danicampora
Copy link
Member Author

danicampora commented Jun 16, 2024

@robert-hh thanks! happy to be back :-)

And replace deprecated macro that was causing the pre-processor
to fail. This is all required to be compatible with newer
releases of Zephyr.

Signed-off-by: danicampora <danicampora@gmail.com>
@dpgeorge
Copy link
Member

Nice to see you @danicampora ! You're always welcome here.

Unfortunately the CI is failing, probably because with the newer Zephyr version other things need updating, eg Bluetooth.

And actually a full update to 3.6.0 was proposed in #9335, but you can see the discussion there about the unfriendly nature of peripheral naming (you now need to specify the address of the peripheral to use it). This whole issue has yet to be resolved, but @jimmo is working on it. Hopefully soon we can update to 3.6.0.

@dpgeorge
Copy link
Member

If it's possible to make a change to the code so that it builds with the existing CI, and also 3.6.0, that would be best (for a short term solution).

@danicampora
Copy link
Member Author

@dpgeorge thanks for pointing out #9335, I should have probably done a search before creating this pull request. I'll dive into #9335 and see how I can help.

@danicampora
Copy link
Member Author

Closing this one in favor of #9335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants