-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: Replace <zephyr/zephyr.h> with <zephyr/kernel.h>. #15291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15291 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 161 161
Lines 21204 21204
=======================================
Hits 20870 20870
Misses 334 334 ☔ View full report in Codecov by Sentry. |
Code size report:
|
7cf201f
to
cd90577
Compare
Hi Daniel. Good to see you back. |
@robert-hh thanks! happy to be back :-) |
cd90577
to
713de46
Compare
And replace deprecated macro that was causing the pre-processor to fail. This is all required to be compatible with newer releases of Zephyr. Signed-off-by: danicampora <danicampora@gmail.com>
713de46
to
39af74a
Compare
Nice to see you @danicampora ! You're always welcome here. Unfortunately the CI is failing, probably because with the newer Zephyr version other things need updating, eg Bluetooth. And actually a full update to 3.6.0 was proposed in #9335, but you can see the discussion there about the unfriendly nature of peripheral naming (you now need to specify the address of the peripheral to use it). This whole issue has yet to be resolved, but @jimmo is working on it. Hopefully soon we can update to 3.6.0. |
If it's possible to make a change to the code so that it builds with the existing CI, and also 3.6.0, that would be best (for a short term solution). |
Closing this one in favor of #9335 |
Also replace deprecated macro (FLASH_AREA_LABEL_EXISTS) that was causing the pre-processor to fail. This is all required to be compatible with newer releases of Zephyr (at least up to V3.6.0)