webassembly: Support top-level await of asyncio Task and Event. #15299
+83
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntoll FYI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15299 +/- ##
=======================================
Coverage 98.42% 98.42%
=======================================
Files 161 161
Lines 21204 21204
=======================================
Hits 20870 20870
Misses 334 334 ☔ View full report in Codecov by Sentry. |
|
ruff a part, and for what is worth it, this looks good to me |
|
|
|
Thank you so much @dpgeorge for this. Can't wait to give it a spin. |
This change allows doing a top-level await on an asyncio primitive like Task and Event. This feature enables a better interaction and synchronisation between JavaScript and Python, because `api.runPythonAsync` can now be used (called from JavaScript) to await on the completion of asyncio primitives. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
webassembly-asyncio-top-level-await
branch
from
3960cb1
to
e9c898c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows doing a top-level await on an asyncio primitive like Task and Event.
This feature enables a better interaction and synchronisation between JavaScript and Python, because
api.runPythonAsynccan now be used (called from JavaScript) to await on the completion of asyncio primitives.