Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py/objdeque.c: correct type flags based on option settings #15316

Closed
wants to merge 1 commit into from

Conversation

dhalbert
Copy link
Contributor

This fixes a minor issue in the changes made by #10724. The type flags for deque were meant to be conditionalized based on MICROPY_PY_COLLECTIONS_DEQUE_ITER, but the computed conditionalized value wasn't used.

Discovered by accident while addressing adafruit#9355. @SAK917 recently added #10724 to CircuitPython via adafruit#9065.

@LordFlashmeow can you confirm this is what you wanted?

Signed-off-by: Dan Halbert <halbert@halwitz.org>
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (88513d1) to head (ea30af3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15316   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         161      161           
  Lines       21204    21204           
=======================================
  Hits        20870    20870           
  Misses        334      334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhalbert
Copy link
Contributor Author

I'm puzzled by the CI failure here: https://github.com/micropython/micropython/actions/runs/9597460366/job/26466587697?pr=15316#step:4:996. Maybe it's something intermittent.

@dpgeorge
Copy link
Member

Thanks for the fix, rebased and merged in 5040b13

(yes the CI is a bit flaky sometimes...)

@dpgeorge
Copy link
Member

See follow up in #15324.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants