Update modhashlib.c : adler32 checksum. #15322
Open
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: massimosala <massimo.sala.71@gmail.com>
massimosala
changed the title
Signed-off-by: massimosala <massimo.sala.71@gmail.com>
|
Code size report: |
|
hashlib is intended to be a subset of the official cpython hashlib, as are all builtins that have a matching name cpython module.
|
|
Yes, as @andrewleech has mentioned, this should be added to zlib, same as in CPython and the signature needs to match. That adds a slight complication since it's recommended that deflate should be preferred to zlib for compression - and so the zlib library is less likely to be included. May be worth a discussion to carefully specify It also needs documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.