windows: Allow specifying the python executable to use for msvc builds #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defaults to 'python' but can be now overridden if needed
|
Ok with me. |
|
So, should this be applied before or after #1538? |
|
Doesn't matter, it is unrelated. |
|
Merged, thanks. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 14, 2019
Without long living them you may clone them when long living a module that uses them. Fixes micropython#1603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to 'python' but can be now overridden if needed
I was trying to set up a CI build but the environment made it annoyingly hard to get python running, and just specifying the full path to the executable (which this commit enables) was by far the easiest solutiion.