stmhal: Pick AF for I2C pins dynamically #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but please make separate commits for the changes to the board files and the I2C stuff. |
mp_hal_gpio_set_af will search for a given function and unit and set the alternate function to the alternate function index found.
This groups the pins for a port together and puts them in numerical order. It also adds ARDUINO pin names.
|
rebased and split into several commits |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
May 14, 2019
The footer already links directly to https://adafru.it/discord, which seems like a more permanent location. I've just replaced the expired link at the top with the same thing.
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
May 14, 2019
fix micropython#1833, replace expired discord link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds I2C2 and I2C3 definitions for the Nucleo 401 board
and fixes up pins.csv
On PYBV10 this increases the flash size by 16 bytes. I suspect that having more peripherals use this mechanism will reduce the code size.
I tested this on a PYBOARD (I2C1 & 2) my CERB40 (I2C1,2,3), and on a NUCLEO-F401RE (I2C1,2,3) board.