stmhal: Rename STM32F401NUCLEO to NUCLEO_F401RE #1871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Underscores are used for ESPRUINO_PICO and NETDUINO_PLUS_2, so would be nice to keep things consistent and use underscore here... except that the hyphen is used in the actual name given by ST to the board, so maybe indeed best to use hyphen here (and in #1870)? Also, probably want to change the MICROPY_HW_BOARD_NAME definition to match the directory name in this case. |
|
Even though the board has a dash, it's probably better to use underscore for consistency. I'll fix both PRs. |
dhylands
force-pushed
the
rename-nucleo
branch
2 times, most recently
from
e201d9a
to
a0bcc72
Compare
This makes the board match the name printed on the board (and agree with the documentation)
Added definitions for SPI1, SPI2, and SPI3 Removed USB stuff (that could be removed) Updated BOARD name defintion
dhylands
changed the title
|
Renamed using underscore |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
May 14, 2019
This should stabilize the sort of files in the .po files. Fixes micropython#1871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the board match the name printed on the board (and
agree with the documentation)