extmod/machine_i2c: Use writes not reads in i2c.scan #2494
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #2449, using write requests instead of read requests for
I2C.scan()
seems to support a larger number of devices (especially ones that are write-only) and to be more compatible with what the hardware i2c on PyBoard does.I have tested this change with a number of I²C devices I have at hand:
<Wire.h>
library (address 9)Especially the last device is problematic, as it pulls down the data line as soon as it encounters any errors in the transmission. Thus, with all four devices connected to the same bus, the "read" scan results in:
Using writes seems to be more robust, as even a read-only I²C device has to implement writes in order to be able to receive the address of the register to read. Using writes, with the same four devices on the bus, the result is: