esp8266/mpconfigport: Enable MICROPY_PY_BUILTINS_SLICE_ATTRS #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's ok, all existing config options are available for being enabled in esp8266 port upon request. (But each such option makes it harder and harder to support 512K modules, which is still on the outlook). Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the resulting firmware larger by 40 bytes on my build.
While I agree that adding support to slicing user objects is a rare case for everyday application code, it is much more common when writing libraries and drivers, especially if one aims for a convenient and intuitive user interface. I stumbled upon the missing attributes trying to write a driver for my 18-channel servo controller (I wanted to be able to set multiple servo positions at once in a single command using slices), but it would also be useful for the NeoPixel and APA LED drivers, LED matrix drivers, display drivers, and basically anything that controls multiple things.