Fix negative temperature in ds18x20 driver #2582
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion on this forum thread http://forum.micropython.org/viewtopic.php?f=16&t=2564#p15232
I think there is a bug in Onewire ds18x20 driver with negative temperatures.
The proposed fix is just for Dallas temperature sensors of 0x28 class. I have no possibility to check for 0x10 but I guess there is a similar issue with negative values.
Fix has been tested and provide correct results for negative temperatures. Code was derived from similar code working for Arduino.