py/modmicropython: Add micropython.kbd_intr() function. #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That what surprises me - don't we have some "port-agnostic" way to set interrupt char already? |
Only at the C level via mp_hal_set_interrupt_char. And this PR is exactly to expose that as a Python function. |
|
Ok, +1 for merging this, I think it's orthogonal to making esp8266's UART object refactor. |
dpgeorge
force-pushed
the
micropython-kbd-intr
branch
from
e41b36f
to
dd0afc5
Compare
It controls the character that's used to (asynchronously) raise a KeyboardInterrupt exception. Passing "-1" allows to disable the interception of the interrupt character (as long as a port allows such a behaviour).
dpgeorge
force-pushed
the
micropython-kbd-intr
branch
from
e353f23
to
c7c14f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function controls the character that's used to (asynchronously) raise a KeyboardInterrupt exception. Passing "-1" allows to disable the interception of the interrupt character (as long as a port allows such a behaviour).
This would fix #2990 and bbcmicrobit/micropython#423, and provide a port-agnostic replacement for stmhal's
USB_VCP.set_interrupt().BUT, there is an alternative, more sophisticated way to do a similar thing: namely to allow to disable (and then restore) the native/built-in REPL stream (eg USB VCP in stmhal, UART0 in esp8266). See #2891 for a PR related to this idea, and also discussion in #2814. It's probably best to go for that solution straight away but it requires some investment to get it to work.