Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix/main: Implement -m option for packages. #3074

Closed
wants to merge 1 commit into from

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented May 7, 2017

No description provided.

@pfalcon
Copy link
Contributor Author

pfalcon commented May 7, 2017

Something which was in technical debt for a while. Works pretty much like CPython, couldn't spot a difference in my testing ;-).

@dpgeorge
Copy link
Member

dpgeorge commented May 9, 2017

Looks ok, but I didn't test it.

@pfalcon
Copy link
Contributor Author

pfalcon commented May 9, 2017

Travis build failure is due to extra condition added to builtinimport.c and minimal port code size increase due to that.

@pfalcon
Copy link
Contributor Author

pfalcon commented May 9, 2017

MSVC strikes again with C99 non-compliance with varlen arrays, switching to use alloca().

@pfalcon
Copy link
Contributor Author

pfalcon commented May 9, 2017

Actually, as usual, vstr_t ends up being used.

@pfalcon
Copy link
Contributor Author

pfalcon commented May 9, 2017

Looks ok, but I didn't test it.

This was mostly to review code patterns used, and well, I had to rewrite it with vstr_t in the end. I pondered about how to implement it and tested well enough, so merging. Maybe we should think how to integrate such command line params tests for unix port into coverage build.

@pfalcon
Copy link
Contributor Author

pfalcon commented May 9, 2017

Merged in edc02bd.

@pfalcon pfalcon closed this May 9, 2017
@pfalcon pfalcon deleted the unix-minus-m-pkg branch May 9, 2017 11:23
@dpgeorge
Copy link
Member

dpgeorge commented May 9, 2017

Maybe we should think how to integrate such command line params tests for unix port into coverage build.

The mechanisms should be there in the cmdline/ tests.

tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Aug 5, 2020
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Jan 21, 2021
This is the same as I added to mpy-cross at e666e86, see micropython#3074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants