py/lexer: Accept \n or \r after line continuation character. #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for an issue with line continuation failing in paste mode due to the lexer only checking for \n in the "following" character position, before next_char() has had a chance to convert \r and \r\n to \n.
This reverts commit 0ebc58e.
Resolves issue where lexer failed to accept CR after line continuation character.
kamtom480
pushed a commit
to kamtom480/micropython
that referenced
this pull request
Jul 1, 2020
…s_warning [main] Custom CSS For "Viewing Outdated Docs" Message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our users ran across another bug in the lexer. If you make use of the line continuation character in paste mode (pasting sample code with long lines) the device throws a SyntaxError.
Minor change requires checking
chr1against both'\n'and'\r'sincenext_char()only performs newline conversions onchr0.And now that I've written that, I realized we can bump the CR LF processing up to the
chr1position fromchr0, simplifying it slightly, and then we'll only see'\r'inchr2(where we need to wait to see if it's followed by a'\n'to consume).