parse: Implement hacky way to handle full range of small ints. #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I proceeded to write testcases for varlen encoded small ints, and that's why I paid attention that parser has its own "small ints" which don't match normal "small ints". So, while my aim was to let people write a billion as a number in uPy, that still can't be done. OMG, let's work around it then, but see TODO below.
Parser has its own "small small ints", which unfortunately means that full
range of small ints are not available in lexical form. This issue is usually
masked by presence of long int, but without them, it's not possible to write
biggish numbers in a Python program.
To work that around, CONST_INT node is overloaded with special encoding for
full-range small ints, which eventually propagated to bytecode properly, as
LOAD_CONST_SMALL_INT.
TODO: Ideally, parser should not have its own "small int" type, and instead
all parts of interpreter should use single consistent type (even if that on
parser side requires more fat representation) - dealing with types fragmented
without real need is a chore.