Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo @ UART7_IRQHandler or.. #4597

Closed
wants to merge 1 commit into from
Closed

Typo @ UART7_IRQHandler or.. #4597

wants to merge 1 commit into from

Conversation

rolandvs
Copy link
Sponsor Contributor

When assuming there is always an UART7 when there is an UART8 then this can be ignored :-)

Assuming there is always a UART7 when UART8 defined nothing have to change :-)
@dpgeorge
Copy link
Member

@chrismas9 does this line up with your changes re UART7/8?

@chrismas9
Copy link
Contributor

I made the same change in the F413 port. It improves readability but makes no change to the code. This is because all STM32 with UART7 also have UART8 and vice versa.

I will rebase before submitting the F413 port so you can merge now or wait for F413 (nearly finished testing).

@dpgeorge
Copy link
Member

Ok, I've merged this in c9eb7eb

@dpgeorge dpgeorge closed this Mar 14, 2019
@rolandvs rolandvs deleted the _fix_stm32_it branch March 14, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants