Javascript additional functionality #4603
Conversation
wolfv
force-pushed
the
javascript_additional_functionality
branch
from
9e0d75e
to
ee752f6
Compare
This adds a simple two way Python to JS bridge and a HTML browser example that demonstrates MicroPython in the browser.
wolfv
force-pushed
the
javascript_additional_functionality
branch
from
ee752f6
to
6151b5f
Compare
|
I guess you were referring to the commit message style? Changed it. |
| @@ -36,6 +36,7 @@ SRC_C = \ | |||
| main.c \ | |||
| mphalport.c \ | |||
| modutime.c \ | |||
| js_module.c \ | |||
There was a problem hiding this comment.
Following how it's done elsewhere, this should be called modjs.c
| @@ -7,16 +7,16 @@ Dependencies | |||
| ------------ | |||
|
|
|||
| Building micropython.js bears the same requirements as the standard MicroPython | |||
| ports with the addition of Emscripten (and uglify-js for the minified file). | |||
| ports with the addition of Emscripten (and uglify-js for the minified file). | |||
There was a problem hiding this comment.
Usually, unrelated changes like fixing things like this whitespace would be done in separate commits, to keep changes self contained and easier to review/understand.
| @@ -0,0 +1,5 @@ | |||
| import js | |||
There was a problem hiding this comment.
Is this file needed at all? If so (as a simple example) it should probably go in the examples/ dir, under a new examples/javascript/ subdir.
|
|
||
| // forward declare emscripten stuff | ||
| void emscripten_run_script(const char *); | ||
| int emscripten_run_script_int(const char *); |
There was a problem hiding this comment.
Does emscripten have a header file for these?
| return mp_const_none; | ||
| } | ||
|
|
||
| STATIC mp_obj_t js_evali(mp_obj_t js_string) { |
There was a problem hiding this comment.
Are there any other return types that could be supported, like float? They don't have to be added now, but good to think how they would be consistently named (eg evalf) if they were added in the future.
| if (__initBrowserCount == 0) | ||
| { | ||
| var mp_js_stdout = document.getElementById('mp_js_stdout'); | ||
| mp_js_stdout.addEventListener('print', function(e) { |
There was a problem hiding this comment.
I think the reason this was done in the html before is so it can be customised for the particular use/app. I guess this default behaviour can still be overridden by a particular app, by changing the event listener?
| } | ||
| }, false); | ||
|
|
||
| mp_js_init(64 * 1024); |
There was a problem hiding this comment.
This was done in the html previously so it could be changed based on need of the app, eg made bigger or smaller. How could it be made customisable?
| { | ||
| mp_js_do_str(document.scripts[i].innerText); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please use the same coding/brace style as already exists in this file.
…n-main Translations update from Weblate
|
Closing due to inactivity. Feel free to reopen with review comments addressed. |
This adds some functionality to the Javascript port:
<script type="script/micropython">tags and executes themmake serverwhich builds and shows thetest.htmlwebpage to see a small example of micropython functionality in the browser