Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope too narrow for MICROPY_EMIT_NATIVE+MICROPY_PERSISTENT_CODE_SAVE #4871

Closed
wants to merge 1 commit into from
Closed

Conversation

pmp-p
Copy link
Contributor

@pmp-p pmp-p commented Jun 24, 2019

n_obj, n_raw_code,
is out of scope for n_obj and n_raw_code .

@@ -404,14 +404,14 @@ STATIC mp_raw_code_t *load_raw_code(mp_reader_t *reader, qstr_window_t *qw) {
ip2[2] = source_file; ip2[3] = source_file >> 8;
}

// Number of entries in constant table
size_t n_obj = read_uint(reader, NULL);
size_t n_raw_code = read_uint(reader, NULL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to work: if kind == MP_CODE_NATIVE_ASM then there should be nothing read from the reader (and see that Travis build fails).

@dpgeorge
Copy link
Member

I see now that this is a duplicate of #4753

@pmp-p
Copy link
Contributor Author

pmp-p commented Jun 25, 2019

indeed, changes offered in #4753 should fix better the problem as soon as they are merged.

@pmp-p pmp-p closed this Jun 25, 2019
@pmp-p pmp-p deleted the patch-7 branch August 8, 2019 14:44
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Jun 23, 2021
It was possible for _only_ a low allocation to be performed.
In this case, `high_head` is NULL, and the comparison
`MP_STATE_VM(first_embedded_allocation) < high_head` would fail.

Closes: micropython#4871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants