scope too narrow for MICROPY_EMIT_NATIVE+MICROPY_PERSISTENT_CODE_SAVE #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Jun 25, 2019
| @@ -404,14 +404,14 @@ STATIC mp_raw_code_t *load_raw_code(mp_reader_t *reader, qstr_window_t *qw) { | |||
| ip2[2] = source_file; ip2[3] = source_file >> 8; | |||
| } | |||
|
|
|||
| // Number of entries in constant table | |||
| size_t n_obj = read_uint(reader, NULL); | |||
| size_t n_raw_code = read_uint(reader, NULL); | |||
There was a problem hiding this comment.
This is not going to work: if kind == MP_CODE_NATIVE_ASM then there should be nothing read from the reader (and see that Travis build fails).
|
I see now that this is a duplicate of #4753 |
|
indeed, changes offered in #4753 should fix better the problem as soon as they are merged. |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Jun 23, 2021
It was possible for _only_ a low allocation to be performed. In this case, `high_head` is NULL, and the comparison `MP_STATE_VM(first_embedded_allocation) < high_head` would fail. Closes: micropython#4871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
micropython/py/persistentcode.c
Line 454 in 5da60ff