Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmel/Microchip XPLAIN BOARD #5011

Closed
wants to merge 9 commits into from
Closed

Atmel/Microchip XPLAIN BOARD #5011

wants to merge 9 commits into from

Conversation

rolandvs
Copy link
Sponsor Contributor

First in a series of the standard Atmel XPLAIN boards featuring the SAMD21J18

@jimmo
Copy link
Member

jimmo commented Aug 16, 2019

Thanks! Please see #4994 for some changes that were made to SAMD configs (sharing the linker files across boards, renaming board.mk).

@rolandvs
Copy link
Sponsor Contributor Author

@jimmo I changed the file accordingly and as a result updated the two other ports and the Makefile too.

@rolandvs
Copy link
Sponsor Contributor Author

rolandvs commented Aug 16, 2019

Also I noticed with my setup that the samd/build-... directories are not ignored in git whereas all other ports do OK.

@jimmo
Copy link
Member

jimmo commented Aug 16, 2019

@rolandvs Can you rebase on master, that will fix the gitignore (this is because #4991 moved the rule to the root .gitignore). Might as well squash while you're rebasing.

Changed to use mpconfigboard.mk instead


renamed board.mk


renamed board.mk
@jimmo
Copy link
Member

jimmo commented Aug 16, 2019

Also, can you move the linker script to the parent directory and rename to the MCU, so that boards with the same MCU can share it. (see the other boards for examples).

@rolandvs rolandvs closed this Aug 16, 2019
@rolandvs rolandvs deleted the XPLAINED_SAMD21J18A branch August 16, 2019 08:32
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Jul 21, 2021
…ypos

Correct type name for EventQueue; EventQueue.overflowed not accessible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants