py: don't add traceback info for finally or re-raised exceptions #5032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2928. It makes sure that traceback info is not added to exceptions that 1) propagate through a finally block; 2) are re-raised with
raise
(no args).Eg, before this patch (see #2928 for the test script):
and after this patch:
(which matches CPython output).
I think this is a good fix, it will improve error messages (not as confusing), and make finally's slightly more efficient (in time and RAM) by not bothering to add the traceback.
The downside is that it increases code size a bit:
Also, it may reduce VM performance (when raising exception) by a tiny amount due to the extra checks, but I didn't yet measure that.