windows/make: Add usage of CFLAGS_EXTRA, LDFLAGS_EXTRA and SRC_MOD consistent with unix port #5074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent with unix port.
|
Is this sufficient to make user C modules work? If so it would be good to mention that in the commit message. |
|
To be honest I'm not sure if this is technically required for USER_C_MODULES, when building with make and mingw32 the USER_C_MODULES handing is already in place. |
|
Looks ok to me, I agree it's a low-risk change. Merged in 380048d |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 4, 2021
Fix a couple fake sleep bugs on nrf and esp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build an existing project using USER_C_MODULES on the windows port, I ran into this Makefile discrepancy with the unix port.
Hopefully this is a low risk addition to the windows port.