Prepare for nrf9160 port #5144
Closed
Prepare for nrf9160 port #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MICROPY_PY_MACHINE_TEMP is set to 0, current code still expect expect Temp for the target device is configured correctly. This patch moves the include of nrf_temp.h until its tested if this feature is requested to be compiled in.
The the nrfx_driver is aware of chip specific registers, while the raw HAL abstraction is not. This driver enables use of NVMC in non-secure domain for nrf9160.
|
Great! Is this ready to go in? (CI passes.) |
|
Yes, ready to go in. I have explicitly tested the microbitfs on both pca10028 (nrf51) and pca10040 (nrf52) to make sure the nrfx_nvmc.c swap works as expected. This is the only change affecting existing targets. |
|
Merged in cf38341. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 13, 2021
Update README.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As first step of adding support for the nrf9160 some small updates on existing modules/drivers in current master is needed to facilitate an easy plugin of nrf9160. These patches should be non-intrusive for existing nrf51/nrf52 targets, but rather allow for nrf52 targets to use peripherals with EasyDMA.